Skip to content

Conversation

@leburgel
Copy link
Member

@leburgel leburgel commented Jan 6, 2025

I randomly noticed that all the DynamicTol calls in the Defaults module passed the algorithm tol as the tol_min of the DynamicTol struct instead of the actual tol_min kwarg. Looked like a typo to me, so thought I should submit a fix in case it is.

@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utility/defaults.jl 52.17% <100.00%> (ø)

... and 60 files with indirect coverage changes

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@lkdvos lkdvos merged commit 19a2cd1 into QuantumKitHub:master Jan 6, 2025
28 checks passed
@leburgel leburgel deleted the lb/pass_tol_min branch January 6, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants