Skip to content

Pass appropriate tol_min in default dynamic tolerances #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 1 commit into from
Jan 6, 2025
Merged

Pass appropriate tol_min in default dynamic tolerances #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/utility/defaults.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
dynamic_tols=dynamic_tols, tol_min=tol_min, tol_max=tol_max,
tol_factor=gauge_tolfactor)
alg = (; tol, maxiter, verbosity)
return dynamic_tols ? DynamicTol(alg, tol, tol_max, tol_factor) : alg
return dynamic_tols ? DynamicTol(alg, tol_min, tol_max, tol_factor) : alg

Check warning on line 43 in src/utility/defaults.jl

View check run for this annotation

Codecov / codecov/patch

src/utility/defaults.jl#L43 

Added line #L43 was not covered by tests
end

function alg_eigsolve(; ishermitian=true, tol=tol, maxiter=maxiter, verbosity=0,
Expand All @@ -50,15 +50,15 @@
tol_factor=eigs_tolfactor)
alg = ishermitian ? Lanczos(; tol, maxiter, eager, krylovdim, verbosity) :
Arnoldi(; tol, maxiter, eager, krylovdim, verbosity)
return dynamic_tols ? DynamicTol(alg, tol, tol_max, tol_factor) : alg
return dynamic_tols ? DynamicTol(alg, tol_min, tol_max, tol_factor) : alg
end

# TODO: make verbosity and maxiter actually do something
function alg_environments(; tol=tol, maxiter=maxiter, verbosity=0,
dynamic_tols=dynamic_tols, tol_min=tol_min, tol_max=tol_max,
tol_factor=envs_tolfactor)
alg = (; tol, maxiter, verbosity)
return dynamic_tols ? DynamicTol(alg, tol, tol_max, tol_factor) : alg
return dynamic_tols ? DynamicTol(alg, tol_min, tol_max, tol_factor) : alg

Check warning on line 61 in src/utility/defaults.jl

View check run for this annotation

Codecov / codecov/patch

src/utility/defaults.jl#L61 

Added line #L61 was not covered by tests
end
function alg_expsolve(; tol=tol, maxiter=maxiter, verbosity=0,
ishermitian=true, krylovdim=krylovdim)
Expand Down
Loading