Skip to content

Conversation

@AFeuerpfeil
Copy link
Contributor

In this PR I refactored the IDMRG interface to simplify overloading the update for specific MPO and MPS types

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@AFeuerpfeil
Copy link
Contributor Author

@lkdvos
Is there a reason, why you use

# write in terms of MultilineMPS
function changebonds(
        ψ::InfiniteMPS, operator::InfiniteMPO, alg, envs = environments(ψ, operator)
    )
    ψ′, envs′ = changebonds(
        convert(MultilineMPS, ψ), convert(MultilineMPO, operator), alg, Multiline([envs])
    )
    return convert(InfiniteMPS, ψ′), envs
end

only for an InfiniteMPO and not also for an InfiniteMPOHamiltonian?
As far as I can tell both use the exact same algorithm, so one could switch to the Multiline case anyway.

@AFeuerpfeil AFeuerpfeil closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant