Skip to content

Fix small errors, use IterativeSolver interface for IDMRG and remove unnecessary type requirements #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AFeuerpfeil wants to merge 2 commits into from
Closed

Fix small errors, use IterativeSolver interface for IDMRG and remove unnecessary type requirements #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89347f
Fix small errors, use IterativeSolver interface for IDMRG and remove …
AFeuerpfeil Oct 31, 2025
1129802
fix formatting
AFeuerpfeil Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/algorithms/grassmann.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ end
"""
retract(state, g, α) -> state′, ξ

Retract a state a distance `α` along a direction `g`, obtaining a new state and the local tangent vector.
Retract a state a distance `α` along a direction `g`, obtaining a new state and the local tangent vector.
"""
function retract(state::FiniteMPS, g, α::Real)
state′ = copy(state)
Expand Down Expand Up @@ -142,9 +142,9 @@ end
Compute the cost function and the tangent vector with respect to the `AL` parameters of the state.
"""
function fg(
state::FiniteMPS, operator::Union{O, LazySum{O}},
state::FiniteMPS, operator,
envs::AbstractMPSEnvironments = environments(state, operator)
) where {O <: FiniteMPOHamiltonian}
)
f = expectation_value(state, operator, envs)
isapprox(imag(f), 0; atol = eps(abs(f))^(3 / 4)) || @warn "MPO might not be Hermitian: $f"
gs = map(1:length(state)) do i
Expand All @@ -155,7 +155,7 @@ function fg(
return real(f), gs
end
function fg(
state::InfiniteMPS, operator::Union{O, LazySum{O}},
state::InfiniteMPS, operator::Union{O, LazySum{O}}, ## TODO: Get rid of this typecheck. Issue: How do we differentiate between InfiniteMPO and InfiniteMPOHamiltonian?
envs::AbstractMPSEnvironments = environments(state, operator)
) where {O <: InfiniteMPOHamiltonian}
recalculate!(envs, state, operator, state)
Expand All @@ -172,7 +172,7 @@ function fg(
return real(f), gs
end
function fg(
state::InfiniteMPS, operator::Union{O, LazySum{O}},
state::InfiniteMPS, operator::Union{O, LazySum{O}}, ## TODO: Get rid of this typecheck. Issue: How do we differentiate between InfiniteMPO and InfiniteMPOHamiltonian?
envs::AbstractMPSEnvironments = environments(state, operator)
) where {O <: InfiniteMPO}
recalculate!(envs, state, operator, state)
Expand Down
Loading