-
Notifications
You must be signed in to change notification settings - Fork 45
[WIP] Implement styles in a top-to-bottom approach #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I really like that we can relax the input types.
|
It definitely feels like it is going in the right direction. An example, how the restriction only for the topmost function in the call tree looks like, is function environments(above::AbstractMPS, op::AbstractMPO, below::AbstractMPS)
return environments(GeometryStyle(above, op, below), OperatorStyle(op), above, op, below)
endand then function environments(::InfiniteChainStyle, ::HamiltonianStyle, above, op, below)
...
end |
I am currently working on getting the algorithms to run for user-defined
AbstractMPStypes.To this end, I will go through the algorithms (currently focussing on
IDMRGandVUMPS) and implement theStyleinterface for the highest-level functions, which are called in these algorithms.Examples for these are
calc_galerkin,expectation_value,environments,recalculate!,(A)C(2)_hamiltonian,transfer_leftenv!,transfer_rightenv!.