Skip to content

[WIP] Implement styles in a top-to-bottom approach #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AFeuerpfeil wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Implement styles in a top-to-bottom approach #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1082142
start adaptation of algorithms to styles
AFeuerpfeil Dec 2, 2025
d45f42e
fix logic
AFeuerpfeil Dec 2, 2025
a4f2ec8
fix test failes due to LazySum
AFeuerpfeil Dec 4, 2025
3d1f6c0
fix formatting and misspelling in last commit
AFeuerpfeil Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/algorithms/groundstate/find_groundstate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ function find_groundstate(
tol = Defaults.tol, maxiter = Defaults.maxiter,
verbosity = Defaults.verbosity, trscheme = nothing
)
if isa(ψ, InfiniteMPS)
if GeometryStyle(ψ) == InfiniteChainStyle()
alg = VUMPS(; tol = max(1.0e-4, tol), verbosity, maxiter)
if tol < 1.0e-4
alg = alg & GradientGrassmann(; tol = tol, maxiter, verbosity)
end
if !isnothing(trscheme)
alg = IDMRG2(; tol = min(1.0e-2, 100tol), verbosity, trscheme) & alg
end
elseif isa(ψ, AbstractFiniteMPS)
elseif GeometryStyle(ψ) == FiniteChainStyle()
alg = DMRG(; tol, maxiter, verbosity)
if !isnothing(trscheme)
alg = DMRG2(; tol = min(1.0e-2, 100tol), verbosity, trscheme) & alg
Expand Down
1 change: 1 addition & 0 deletions src/algorithms/groundstate/idmrg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ end

function find_groundstate(mps, operator, alg::alg_type, envs = environments(mps, operator)) where {alg_type <: Union{<:IDMRG, <:IDMRG2}}
(length(mps) ≤ 1 && alg isa IDMRG2) && throw(ArgumentError("unit cell should be >= 2"))
GeometryStyle(operator, mps) != InfiniteChainStyle() && throw(ArgumentError("IDMRG only supports infinite systems."))
log = alg isa IDMRG ? IterLog("IDMRG") : IterLog("IDMRG2")
mps = copy(mps)
iter = 0
Expand Down
3 changes: 2 additions & 1 deletion src/algorithms/groundstate/vumps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct VUMPSState{S, O, E}
end

function find_groundstate(
mps::InfiniteMPS, operator, alg::VUMPS, envs = environments(mps, operator)
mps, operator, alg::VUMPS, envs = environments(mps, operator)
)
return dominant_eigsolve(operator, mps, alg, envs; which = :SR)
end
Expand All @@ -55,6 +55,7 @@ function dominant_eigsolve(
operator, mps, alg::VUMPS, envs = environments(mps, operator);
which
)
GeometryStyle(operator, mps) != InfiniteChainStyle() && throw(ArgumentError("VUMPS only supports infinite systems."))
log = IterLog("VUMPS")
iter = 0
ϵ = calc_galerkin(mps, operator, mps, envs)
Expand Down
3 changes: 3 additions & 0 deletions src/operators/lazysum.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Base.complex(x::LazySum) = LazySum(complex.(x.ops))
TimeDependence(x::LazySum) = istimed(x) ? TimeDependent() : NotTimeDependent()
istimed(x::LazySum) = any(istimed, x)

OperatorStyle(::Type{LazySum{O}}) where {O} = OperatorStyle(O)
GeometryStyle(::Type{LazySum{O}}) where {O} = GeometryStyle(O)

# constructors
LazySum(x) = LazySum([x])
LazySum(ops::AbstractVector, fs::AbstractVector) = LazySum(map(MultipliedOperator, ops, fs))
Expand Down