Skip to content

Compatibility with MultiTensorKit #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Compatibility with MultiTensorKit #297

wants to merge 46 commits into from

Conversation

borisdevos
Copy link
Member

@borisdevos borisdevos commented Jun 13, 2025 •
edited
Loading

This PR provides the changes required to be able to consider the BimoduleSectors of MultiTensorKit.

All changes boil down to either

  1. not being able to evaluate the oneunit of a BimoduleSector, or
  2. not being able to use braiding tensors for BimoduleSector GradedSpaces,
    and finding ways around to this.

A potential thing to add is tests with BimoduleSector MPS/MPOs or so? For this, I would need to first complete benchmarking MultiTensorKit, hence the draft PR. I might also need to format.

borisdevos added 17 commits March 25, 2025 17:30
@borisdevos
add_util_leg spinoff for MPOHamiltonian
a724420
@borisdevos
apply add_util_mpoleg to correlator
eeefc58
@borisdevos
use add_util_mpoleg in FiniteMPO
909e453
@borisdevos
use add_util_mpoleg in test on correlator
03d4001
@borisdevos
avoid oneunit(S) in one constructor of InfiniteMPOHamiltonian
2abc2ff
@borisdevos
avoid oneunit(S) in one constructor of FiniteMPOHamiltonian
822d728
@borisdevos
remove type LocalOperator in _oneunit
4c1345e
@borisdevos
remove braidings in left/right_excitation_transfer_system of `Infin…
9b569d4 
…iteMPOHamiltonian`
@borisdevos
typo in right_excitation_transfer_system
8de0443
@borisdevos
rewrite (In)FiniteMPOHamiltonian and the way oneunit was avoided
5fbd831
@borisdevos
Merge branch 'master' of https://github.com/borisdevos/MPSKit.jl into…
b981601 
… boris-MTK-compat
@borisdevos
avoid oneunit(spacetype(H)) evaluation
c28a9c1
@borisdevos
super important typo
37cecd3
@borisdevos
Merge branch 'master' of https://github.com/QuantumKitHub/MPSKit.jl i…
eba85c5 
…nto boris-MTK-compat
@borisdevos
remove comments
f584d2b
@borisdevos
get return_type in excitations to evaluate the sector kwarg
f8f6c2c
@borisdevos
typo
889873a
@borisdevos borisdevos marked this pull request as ready for review July 18, 2025 06:48
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/fixedpoint.jl 0.00% 3 Missing ⚠️
...c/algorithms/excitation/quasiparticleexcitation.jl 75.00% 1 Missing ⚠️
src/algorithms/groundstate/gradient_grassmann.jl 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/ED.jl 100.00% <100.00%> (ø)
src/algorithms/correlators.jl 90.90% <100.00%> (ø)
src/algorithms/toolbox.jl 95.15% <100.00%> (ø)
src/operators/mpo.jl 90.25% <100.00%> (ø)
src/operators/mpohamiltonian.jl 87.59% <100.00%> (+0.14%) ⬆️
src/utility/utility.jl 71.42% <100.00%> (-4.53%) ⬇️
...c/algorithms/excitation/quasiparticleexcitation.jl 76.42% <75.00%> (-0.22%) ⬇️
src/algorithms/groundstate/gradient_grassmann.jl 75.00% <0.00%> (ø)
src/algorithms/fixedpoint.jl 60.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lkdvos
lkdvos reviewed Aug 26, 2025
View reviewed changes
lkdvos
lkdvos reviewed Aug 28, 2025
View reviewed changes
@borisdevos borisdevos mentioned this pull request Aug 28, 2025
Merged
@borisdevos
import TestSetup module, remove unused deps + add variance tests
b31ffa1
@borisdevos
specify allowed spin for Z2 S_zz + don't use deprecated call
03dbee3
@borisdevos
add variance tests for FiniteMPS + allow it to be negative (?) + ad…
a17874a 
…d `FiniteExcited` test
@borisdevos
Merge branch 'master' of https://github.com/QuantumKitHub/MPSKit.jl i…
2c96ab1 
…nto boris-MTK-compat
@borisdevos
Revert "Merge branch 'master' of https://github.com/QuantumKitHub/MPS…
fdd95c7 
…Kit.jl into boris-MTK-compat"

This reverts commit 2c96ab1, reversing
changes made to a17874a.
@borisdevos
Revert "Revert "Merge branch 'master' of https://github.com/QuantumKi…
54a4f74 
…tHub/MPSKit.jl into boris-MTK-compat""

This reverts commit fdd95c7.
@borisdevos
Revert "Merge branch 'master' of https://github.com/QuantumKitHub/MPS…
2f1108e 
…Kit.jl into boris-MTK-compat"

This reverts commit 2c96ab1, reversing
changes made to 8cf041f.
@borisdevos
Revert "Revert "Merge branch 'master' of https://github.com/QuantumKi…
8d83a82 
…tHub/MPSKit.jl into boris-MTK-compat""

This reverts commit 2f1108e.
@borisdevos
fix the messed up merges hopefully
a2027b0
@borisdevos
format
05e33dd
@borisdevos
actually format everything
ca03f89
@borisdevos
Copy link
Member Author

Wow it's been a while since I messed up so much with git 😅
Multifusion tests fail because IsingBimodule-graded spaces is still a WIP (QuantumKitHub/TensorKit.jl#263).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdvos lkdvos lkdvos left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borisdevos @lkdvos