Skip to content

Allow AbstractArray as data of PeriodicArray #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AFeuerpfeil wants to merge 2 commits into from
Closed

Allow AbstractArray as data of PeriodicArray #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6738455
Allo the data of PeriodicArray to be any AbstractArray
AFeuerpfeil Nov 6, 2025
1f9e6a9
fix similar for InfiniteMPOHamiltonian
AFeuerpfeil Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/operators/mpohamiltonian.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function FiniteMPOHamiltonian(Ws::AbstractVector{O}) where {O <: MPOTensor}
return FiniteMPOHamiltonian{O}(Ws)
end

const InfiniteMPOHamiltonian{O <: MPOTensor} = MPOHamiltonian{O, PeriodicVector{O}}
const InfiniteMPOHamiltonian{O <: MPOTensor} = MPOHamiltonian{O, <:PeriodicVector{O}}
Base.isfinite(::Type{<:InfiniteMPOHamiltonian}) = false

function InfiniteMPOHamiltonian(Ws::AbstractVector{O}) where {O <: MPOTensor}
Expand Down
26 changes: 16 additions & 10 deletions src/utility/periodicarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,17 @@ A[-1, 1], A[1, 1], A[4, 5]

See also [`PeriodicVector`](@ref), [`PeriodicMatrix`](@ref)
"""
struct PeriodicArray{T, N} <: AbstractArray{T, N}
data::Array{T, N}
struct PeriodicArray{T, N, A <: AbstractArray{T, N}} <: AbstractArray{T, N}
data::A
PeriodicArray{T,N}(data::A) where A <: AbstractArray{T,N} where {T,N} = new{T,N,A}(data)
PeriodicArray{T,N,A}(data::A) where A <: AbstractArray{T,N} where {T,N} = new{T,N,A}(data)
end
PeriodicArray(data::AbstractArray{T, N}) where {T, N} = PeriodicArray{T, N}(data)
PeriodicArray{T}(data::AbstractArray{T, N}) where {T, N} = PeriodicArray{T, N}(data)
PeriodicArray(data::AbstractArray{T,N}) where {T,N} = PeriodicArray{T,N}(data)
PeriodicArray{T}(data::AbstractArray{T,N}) where {T,N} = PeriodicArray{T,N}(data)




function PeriodicArray{T}(initializer, args...) where {T}
return PeriodicArray(Array{T}(initializer, args...))
end
Expand Down Expand Up @@ -88,15 +94,15 @@ end
Base.BroadcastStyle(::Type{T}) where {T <: PeriodicArray} = Broadcast.ArrayStyle{T}()

function Base.similar(
bc::Broadcast.Broadcasted{<:Broadcast.ArrayStyle{<:PeriodicArray}}, ::Type{T}
) where {T}
return PeriodicArray(similar(Array{T}, axes(bc)))
bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{PeriodicArray{T, N, A}}}, ::Type{ElType}
) where {A <: AbstractArray{T, N}} where {T, N, ElType}
return PeriodicArray(similar(convert(Broadcast.Broadcasted{typeof(Broadcast.BroadcastStyle(A))}, bc), ElType))
end

# Conversion
# ----------
Base.convert(::Type{T}, A::AbstractArray) where {T <: PeriodicArray} = T(A)
Base.convert(::Type{PeriodicArray}, A::AbstractArray) = PeriodicArray(A)
Base.convert(::Type{T}, A::PeriodicArray) where {T <: AbstractArray} = convert(T, parent(A))
# fix ambiguities
Base.convert(::Type{T}, A::PeriodicArray) where {T <: PeriodicArray} = A
Base.convert(::Type{T}, A::PeriodicArray) where {T <: Array} = parent(A)
Base.convert(::Type{PeriodicArray}, A::PeriodicArray) = A
Base.convert(::Type{T}, A::PeriodicArray) where {T <: AbstractArray} = convert(T, parent(A))
Loading