Implement GeometryStyle for AbstractMPS#355
Closed
AFeuerpfeil wants to merge 9 commits intoQuantumKitHub:mainfrom
Closed
Implement GeometryStyle for AbstractMPS#355AFeuerpfeil wants to merge 9 commits intoQuantumKitHub:mainfrom
GeometryStyle for AbstractMPS#355AFeuerpfeil wants to merge 9 commits intoQuantumKitHub:mainfrom
Conversation
Rephrase error messages based on Lukas' suggestion Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the methods
AC2,dot,isapprox,norm,normalize(!)as well as the left and right fixedpoints for anAbstractMPSby dispatching onGeometryStyle. These functions will be overloaded for the different types of MPS andGeometryStylein future commits.This commit should not break anything, because these functions have more specialized definitions for each of the
AbstractMPStypes, so should not be called at all right now.Examples for future overloads are
for the
FiniteMPSandfor the
InfiniteMPS.