Skip to content

Fix LatticePoint subtraction #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 1 commit into from
Apr 14, 2025
Merged

Fix LatticePoint subtraction #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lattices/latticepoints.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
Base.:+(i::Int, j::LatticePoint{1}) = j + i

function Base.:-(i::LatticePoint{N}, j::NTuple{N,Int}) where {N}
return LatticePoint(i.coordinates .+ j, i.lattice)
return LatticePoint(i.coordinates .- j, i.lattice)
end
Base.:-(i::LatticePoint{1}, j::Int) = LatticePoint(i.coordinates .+ j, i.lattice)
Base.:-(i::LatticePoint{1}, j::Int) = LatticePoint(i.coordinates .- j, i.lattice)

Check warning on line 57 in src/lattices/latticepoints.jl

View check run for this annotation

Codecov / codecov/patch

src/lattices/latticepoints.jl#L57 

Added line #L57 was not covered by tests
function Base.:-(i::NTuple{N,Int}, j::LatticePoint{N}) where {N}
return LatticePoint(i .- j.coordinates, j.lattice)
end
Expand Down
Loading