Skip to content

WIP CUDA support #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 16 commits into from
Aug 12, 2025
Merged

WIP CUDA support #20

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2e4451b
first cuda commit - qr support
Jutho Apr 17, 2025
4b738a0
first fixes
Jutho Apr 17, 2025
056341e
working qr
Jutho Apr 20, 2025
6a1490e
small triangular! fix
Jutho Apr 20, 2025
71737d7
add LQViaTransposedQR, CUDA LQ and tests
Jutho Apr 22, 2025
88678f3
first svd support
Jutho May 1, 2025
5df81c1
Jacobi SVD algorithm
Jutho May 11, 2025
76c2329
Fix default_algorithm for CUDA matrices
kshyatt Aug 9, 2025
31adc07
Try running GPU tests with buildkite
kshyatt Aug 11, 2025
9ca46a0
Dumb typo
kshyatt Aug 11, 2025
d8ada04
Another silly ENV mistake
Aug 11, 2025
8327a57
Cover extension directory also in coverage
Aug 11, 2025
2c2a2a6
Fix envvar name
Aug 11, 2025
da70492
Soothe JET
Aug 11, 2025
e732330
Add GPU tests for LTS release
Aug 11, 2025
4fe347c
Set LTS version manually
Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/implementations/lq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ function lq_via_qr!(A::AbstractMatrix, L::AbstractMatrix, Q::AbstractMatrix,
qr_alg::AbstractAlgorithm)
m, n = size(A)
minmn = min(m, n)
At = adjoint!(similar(A'), A)
At = adjoint!(similar(A'), A)::AbstractMatrix
Copy link
Member Author

@Jutho Jutho Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, this is where the type assert was added. Is this only JET that complains, or was there really a type instability or type inference issue? I cannot see how asserting an abstract type would help with anything.

Qt = (A === Q) ? At : similar(Q')
Lt = similar(L')
if size(Q) == (n, n)
Expand All @@ -197,9 +197,9 @@ end
function lq_null_via_qr!(A::AbstractMatrix, N::AbstractMatrix, qr_alg::AbstractAlgorithm)
m, n = size(A)
minmn = min(m, n)
At = adjoint!(similar(A'), A)
At = adjoint!(similar(A'), A)::AbstractMatrix
Nt = similar(N')
Nt = qr_null!(At, Nt, qr_alg)
!isempty(N) && adjoint!(N, Nt)
return N
end
end