-
Notifications
You must be signed in to change notification settings - Fork 5
[WIP] Attempting to wrap randomized SVD #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I haven't looked at this in detail yet. Do you think |
|
Could well do better there since for best performance/accuracy |
|
The reason I didn't do this at first I think is that |
|
I do have somewhere on my todo list to make the I think I agree with Jutho though, that this might make more sense as an |
|
If we can modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I left some minor comments, but otherwise I'm happy to merge. (GPU CI runs now right?)
|
CI does now run! |
Attempted to wrap the randomized SVD method which relies on oversampling and the power method. Definitely open to some interface improvements here! Also, the ugly look of the tests suggests perhaps we should extend
diagviewa little...