Skip to content

Loosen types on polar copy_input to work with TensorMap #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshyatt merged 1 commit into from
Aug 18, 2025
Merged

Loosen types on polar copy_input to work with TensorMap #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/implementations/polar.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Inputs
# ------
copy_input(::typeof(left_polar), A::AbstractMatrix) = copy_input(svd_full, A)
copy_input(::typeof(right_polar), A::AbstractMatrix) = copy_input(svd_full, A)
copy_input(::typeof(left_polar), A) = copy_input(svd_full, A)
copy_input(::typeof(right_polar), A) = copy_input(svd_full, A)

function check_input(::typeof(left_polar!), A::AbstractMatrix, WP)
m, n = size(A)
Expand Down
6 changes: 3 additions & 3 deletions src/implementations/svd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Inputs
# ------
function copy_input(::typeof(svd_full), A::AbstractMatrix)
function copy_input(::typeof(svd_full), A)
return copy!(similar(A, float(eltype(A))), A)
end
copy_input(::typeof(svd_compact), A::AbstractMatrix) = copy_input(svd_full, A)
copy_input(::typeof(svd_vals), A::AbstractMatrix) = copy_input(svd_full, A)
copy_input(::typeof(svd_compact), A) = copy_input(svd_full, A)
copy_input(::typeof(svd_vals), A) = copy_input(svd_full, A)
copy_input(::typeof(svd_trunc), A) = copy_input(svd_compact, A)

# TODO: many of these checks are happening again in the LAPACK routines
Expand Down
Loading