Skip to content

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Sep 29, 2025

These are a couple corrections after the pullback updates, using the correct tolerance for determining the rank, and avoiding to overwrite the input tangents

@lkdvos lkdvos requested a review from Jutho September 29, 2025 11:33
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pullbacks/svd.jl 96.26% <100.00%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos merged commit efffc59 into main Sep 29, 2025
10 checks passed
@lkdvos lkdvos deleted the ld-fixes branch September 29, 2025 14:11
lkdvos added a commit that referenced this pull request Sep 29, 2025
* use `rank_atol` for determining SVD rank

* avoid overwriting input tangents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants