More consistent API for when to have _full, _compact, ...
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Jutho
reviewed
Oct 1, 2025
lkdvos
changed the title
qr_compact_pullback! and lq_compact_pullback! for qr_pullback! and lq_pullback!_full, _compact, ...
lkdvos
force-pushed
the
ld-qrlqpullback
branch
from
13854af to
6f21929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
qr_compact_pullback!(lq_compact_pullback!) withqr_pullback!(lq_pullback!) since these methods also work for the full case.Additionally I removed some unused and unexported API that were remnants of old code.
I also fixed the formatting in some of the docstrings.