Fix gauge fixing in :fixed mode for non-uniform unit cells from full SVD#249
Merged
Fix gauge fixing in :fixed mode for non-uniform unit cells from full SVD#249
:fixed mode for non-uniform unit cells from full SVD#249Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
The random cartesian spaces test should be fixed, so hopefully now everything runs through. I also added a line to the |
lkdvos
previously approved these changes
Aug 26, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Suggested a slight reorganization of the code, otherwise happy to merge once tests pass (also happy to merge like this)
lkdvos
approved these changes
Aug 26, 2025
lkdvos
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when using
:fixedmode differentiation the gauge fixing routine would error for non-uniform unit cells when using a full SVD (as opposed aIterSVD). This came down the fact that the gauge signs on the full space were initialized with the wrong spaces. Now we explicitly initialize the correct spaces which is also tested in thetest/ctmrg/unitcell.jltests.