-
Notifications
You must be signed in to change notification settings - Fork 26
Add bipartite specialization of belief propagation and gauging #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yue-Zhengyuan
wants to merge
5
commits into
QuantumKitHub:master
Choose a base branch
from
Yue-Zhengyuan:bp-bipartite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−15
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c34c63b
Add bipartite specialization of belief propagation
Yue-Zhengyuan e3d3446
Fix formatting
Yue-Zhengyuan 67d84e6
Fix bipartite SU test
Yue-Zhengyuan 7dcf1a9
Rename variable
Yue-Zhengyuan d024ca9
Avoid double `map` calls
Yue-Zhengyuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,16 @@ Algorithm for gauging PEPS with belief propagation fixed point messages. | |
| # TODO: add options | ||
| end | ||
|
|
||
| function _bpenv_bipartite_check(env::BPEnv) | ||
| for (r, c) in Iterators.product(1:2, 1:2) | ||
| r′, c′ = _next(r, 2), _next(c, 2) | ||
| if !all(env[:, r, c] .== env[:, r′, c′]) | ||
| return false | ||
| end | ||
| end | ||
| return true | ||
| end | ||
|
|
||
| """ | ||
| gauge_fix(psi::Union{InfinitePEPS, InfinitePEPO}, alg::BPGauge, env::BPEnv) | ||
|
|
||
|
|
@@ -15,11 +25,19 @@ an [`InfinitePEPO`](@ref) interpreted as purified state with two physical legs) | |
| using fixed point environment `env` of belief propagation. | ||
| """ | ||
| function gauge_fix(psi::InfinitePEPS, alg::BPGauge, env::BPEnv) | ||
| bipartite = _state_bipartite_check(psi) && _bpenv_bipartite_check(env) | ||
| psi′ = copy(psi) | ||
| XXinv = map(eachcoordinate(psi, 1:2)) do I | ||
| _, X, Xinv = _bp_gauge_fix!(CartesianIndex(I), psi′, env) | ||
| return X, Xinv | ||
| end | ||
| if bipartite | ||
| # copy 1st column to 2nd column to eliminate differences | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried not to do the useless update of the 2nd column before copying from the 1st column. But then |
||
| # caused by order of applying gauge transformations | ||
| for r in 1:2 | ||
| psi′[_next(r, 2), 2] = copy(psi′[r, 1]) | ||
| end | ||
| end | ||
| return psi′, XXinv | ||
| end | ||
| function gauge_fix(psi::InfinitePEPO, alg::BPGauge, env::BPEnv) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's not easier to follow if we just write this out manually, calling similar and writing out the coordinates like that.
It probably doesn't matter all that much but I'd like to avoid the double
mapcall, which allocates twiceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance suggestions are always welcome :) But this way, if we want to differentiate through BP, I guess we must use Mooncake/Enzyme (with mutation support)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point! I guess already the
normalize!call might be a problem, but then maybe it's just fine to merge as is