add unthunk in rrules of eig! eigh! leftorth! rightorth! #207
Merged
Jutho merged 4 commits intoQuantumKitHub:masterfrom Jan 18, 2025
Merged
add unthunk in rrules of eig! eigh! leftorth! rightorth! #207Jutho merged 4 commits intoQuantumKitHub:masterfrom
unthunk in rrules of eig! eigh! leftorth! rightorth! #207Jutho merged 4 commits intoQuantumKitHub:masterfrom
Conversation
Member
|
Great; we just fixed this for SVD but should have known that this would also have been an issue with the other factorisations. Thanks for fixing this. Good that I haven't tagged 0.14.3 yet, this should definitely be part of it. I will merge this when the tests turn green, and then tag 0.14.3. |
Jutho
reviewed
Jan 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 82.17% 82.18% +0.01%
==========================================
Files 42 42
Lines 5380 5384 +4
==========================================
+ Hits 4421 4425 +4
Misses 959 959 ☔ View full report in Codecov by Sentry. |
tangwei94
commented
Jan 18, 2025
Contributor
Author
tangwei94
left a comment
tangwei94
left a comment
There was a problem hiding this comment.
using explicit resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
eig!eigh!leftorth!rightorth!are followed by tensor contractions implemented withTensorOperations.jl, the backward would fail. Addingunthunkto therrules of these functions fixes this issue.