Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 82.64% 82.65% +0.01%
==========================================
Files 43 43
Lines 5559 5593 +34
==========================================
+ Hits 4594 4623 +29
- Misses 965 970 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return U1Space((s => d for (s, d) in zip(sectors, dims))...) | ||
| end | ||
| function generate_space(::Type{SU2Irrep}, D::Int, sigma::Real=0.5) | ||
| poisson_pdf(x) = ceil(Int, D * exp(-sigma) * sigma^x / factorial(x)) |
There was a problem hiding this comment.
Strictly speaking, this is not correctly normalised. If we assume that SU2Irrep(j) is indeed generated with dimension poisson_pdf(2*j) = D * exp(-sigma) * sigma^(2j) / factorial(2j), then the total dimension is, with n=2j
due to the extra factor
Maybe poisson_pdf(x) = ceil(Int, D * exp(-sigma) * sigma^x / factorial(x) / (x+1))
which happens to be
Maybe poisson_pdf(x) = ceil(Int, D * exp(-sigma) * sigma^x / factorial(x+1))
as alternative
There was a problem hiding this comment.
Also, for large sigma, the poisson distribution is peaked away from zero, so I do not know if that is really the distribution we want, versus just a half gaussian, but I guess those details don't really matter (but we probably do not want to change them afterwards).
There was a problem hiding this comment.
I'm definitely happy to switch that, although I think the peak is reasonable too: I like poisson for SU(2) since in the Heisenberg virtual spaces often there are more values of spin 1 than spin 0.
Probably it doesn't matter too much for the actual representativeness of the benchmarks though
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
This sets up a
benchmark/benchmarks.jlscript to have a dedicatedSUITEto run our benchmarks, similar toBaseBenchmarks.jl.The goal is to start adding more coverage so we can better assess the actual performance improvements and/or regressions between versions.
(This is not meant as being illustrative for the performance of this package, for which I am creating separate scripts to generate proper figures etc)