Skip to content

Fix TruncationIntersection implementation and test #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 2 commits into from
Oct 15, 2025
Merged

Fix TruncationIntersection implementation and test #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b53ddf
some more small truncation fixes
lkdvos Oct 10, 2025
d704080
add tests
lkdvos Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/factorizations/truncation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,19 @@ function MAK.findtruncated_svd(values::SectorDict, strategy::TruncationSpace)
end

function MAK.findtruncated(values::SectorDict, strategy::TruncationIntersection)
inds = map(Base.Fix1(MAK.findtruncated, values), strategy)
inds = map(Base.Fix1(MAK.findtruncated, values), strategy.components)
return SectorDict(
c => mapreduce(
Base.Fix2(getindex, c), _ind_intersect, inds;
Base.Fix2(getindex, c), MatrixAlgebraKit._ind_intersect, inds;
init = trues(length(values[c]))
) for c in intersect(map(keys, inds)...)
)
end
function MAK.findtruncated_svd(Sd::SectorDict, strategy::TruncationIntersection)
inds = map(Base.Fix1(MAK.findtruncated_svd, Sd), strategy)
function MAK.findtruncated_svd(values::SectorDict, strategy::TruncationIntersection)
inds = map(Base.Fix1(MAK.findtruncated_svd, values), strategy.components)
return SectorDict(
c => mapreduce(
Base.Fix2(getindex, c), _ind_intersect, inds;
Base.Fix2(getindex, c), MatrixAlgebraKit._ind_intersect, inds;
init = trues(length(values[c]))
) for c in intersect(map(keys, inds)...)
)
Expand Down
8 changes: 8 additions & 0 deletions test/factorizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,14 @@ for V in spacelist
@test isisometry(U4)
@test isisometry(Vᴴ4; side = :right)
@test norm(t - U4 * S4 * Vᴴ4) <= 0.5

trunc = truncrank(dim(domain(S)) ÷ 2) & trunctol(; atol = λ - 10eps(λ))
U5, S5, Vᴴ5 = @constinferred svd_trunc(t; trunc)
@test t * Vᴴ5' ≈ U5 * S5
@test isisometry(U5)
@test isisometry(Vᴴ5; side = :right)
@test minimum(minimum, values(LinearAlgebra.diag(S5))) >= λ
@test dim(domain(S5)) ≤ dim(domain(S)) ÷ 2
end
end

Expand Down
Loading