Skip to content

Move bugfixes Zygote tests to AD tests #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 2 commits into from
Jan 5, 2026
Merged

Move bugfixes Zygote tests to AD tests #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70513dd
Move bugfixes Zygote tests to AD tests
kshyatt Jan 5, 2026
43d2bc2
Merge branch 'main' into ksh/ad
lkdvos Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test/autodiff/ad.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,3 +628,45 @@ for V in spacelist
end
end
end

# https://github.com/quantumkithub/TensorKit.jl/issues/201
@testset "Issue #201" begin
function f(A::AbstractTensorMap)
U, S, V, = svd_compact(A)
return tr(S)
end
function f(A::AbstractMatrix)
S = LinearAlgebra.svdvals(A)
return sum(S)
end
A₀ = randn(Z2Space(4, 4) ← Z2Space(4, 4))
grad1, = Zygote.gradient(f, A₀)
grad2, = Zygote.gradient(f, convert(Array, A₀))
@test convert(Array, grad1) ≈ grad2

function g(A::AbstractTensorMap)
U, S, V, = svd_compact(A)
return tr(U * V)
end
function g(A::AbstractMatrix)
U, S, V, = LinearAlgebra.svd(A)
return tr(U * V')
end
B₀ = randn(ComplexSpace(4) ← ComplexSpace(4))
grad3, = Zygote.gradient(g, B₀)
grad4, = Zygote.gradient(g, convert(Array, B₀))
@test convert(Array, grad3) ≈ grad4
end

# https://github.com/quantumkithub/TensorKit.jl/issues/209
@testset "Issue #209" begin
function f(T, D)
@tensor T[1, 4, 1, 3] * D[3, 4]
end
V = Z2Space(2, 2)
D = DiagonalTensorMap(randn(4), V)
T = randn(V ⊗ V ← V ⊗ V)
g1, = Zygote.gradient(f, T, D)
g2, = Zygote.gradient(f, T, TensorMap(D))
@test g1 ≈ g2
end
43 changes: 0 additions & 43 deletions test/other/bugfixes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ using Test, TestExtras
using TensorKit
using TensorOperations
using LinearAlgebra: LinearAlgebra
using Zygote

@testset "BugfixConvert" begin
v = randn(
Expand Down Expand Up @@ -43,45 +42,3 @@ end
@test storagetype(t5) == Vector{Float64}
tensorfree!(t2)
end

# https://github.com/quantumkithub/TensorKit.jl/issues/201
@testset "Issue #201" begin
function f(A::AbstractTensorMap)
U, S, V, = svd_compact(A)
return tr(S)
end
function f(A::AbstractMatrix)
S = LinearAlgebra.svdvals(A)
return sum(S)
end
A₀ = randn(Z2Space(4, 4) ← Z2Space(4, 4))
grad1, = Zygote.gradient(f, A₀)
grad2, = Zygote.gradient(f, convert(Array, A₀))
@test convert(Array, grad1) ≈ grad2

function g(A::AbstractTensorMap)
U, S, V, = svd_compact(A)
return tr(U * V)
end
function g(A::AbstractMatrix)
U, S, V, = LinearAlgebra.svd(A)
return tr(U * V')
end
B₀ = randn(ComplexSpace(4) ← ComplexSpace(4))
grad3, = Zygote.gradient(g, B₀)
grad4, = Zygote.gradient(g, convert(Array, B₀))
@test convert(Array, grad3) ≈ grad4
end

# https://github.com/quantumkithub/TensorKit.jl/issues/209
@testset "Issue #209" begin
function f(T, D)
@tensor T[1, 4, 1, 3] * D[3, 4]
end
V = Z2Space(2, 2)
D = DiagonalTensorMap(randn(4), V)
T = randn(V ⊗ V ← V ⊗ V)
g1, = Zygote.gradient(f, T, D)
g2, = Zygote.gradient(f, T, TensorMap(D))
@test g1 ≈ g2
end
Loading