Basic tensor support for AMDGPU #341
Open
+801
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
lkdvos
previously approved these changes
Jan 5, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
In principle looks good to me!
Do we want to wait with the AMD support until the dust settles on CUDA (mostly to avoid having to duplicate things we might still change), or should we just go ahead with this?
Member
Author
|
This doesn't include factorization stuff which is the only inflight CUDA thing, I think? Most of the diff is the tests, tbh |
Member
|
The tests is actually what I was thinking of, but maybe it's really not that bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied from the CUDA support