Reduce cache footprint by decoupling degeneracy-dependent data#387
Open
Reduce cache footprint by decoupling degeneracy-dependent data#387
Conversation
Codecov Report❌ Patch coverage is
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the internal block structure representation for
TensorMapby splittingFusionBlockStructureinto two separately-cached structs:SectorStructure(cached by sector structure, shared across spaces with the same sectors): coupled sectors and valid fusion tree pairs asDictionaries.Indices.DegeneracyStructure(cached perHomSpace): total dimension, block sizes/ranges, and sub-block strides as plainVectors.The public
blockstructure(W)andsubblockstructure(W)combine these on the fly into aDictionary.Previously,
FusionBlockStructurestored afusiontreelist, afusiontreeindiceslookup dict, and afusiontreestructurevector — the tree pairs were stored twice and lookup required manual indirection.Dictionaries.jlhandles this naturally via its token system.A secondary benefit:
DegeneracyStructure{N}is parameterized only by the number of indicesN, not the sector type. Kernels that only need sizes/strides/offsets can therefore be compiled once and reused across different symmetry groups — a potential route to much faster precompilation.Also moves the tensor structure computation out of
homspace.jlinto a newtensorstructure.jl.Open questions:
Dictionaries.jltypes to avoid maintaining two APIs?