Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
I will update the PR tonight, as I still have to install the Runic formatter in my VSCode at the office. |
|
Ok, with some delay, here are the updates. I also figured out and implemented the correct braiding rules for the But this was not how it was used in the |
|
I don't understand the JET error, nor why it only happens on Julia latest on Mac and Ubuntu. |
src/groupelements.jl
Outdated
| if p == 0 | ||
| R = 1 | ||
| elseif N == 2 && p == 1 | ||
| R = ifelse(a.n == b.n == 1, -1.0, 1.0) |
There was a problem hiding this comment.
In principle we could specialize the cocycle and Rsymbol for this case to return Int if I'm not mistaken, but this might not really be worth it
There was a problem hiding this comment.
Yes, I had this at first. But it seems that also for SU2Irrep we return ±1.0 so I opted for floating point. Of course, in that case the Fsymbol definitely needs floating point numbers, so yes, the N ==2 && p == 1 case could use integers for both Fsymbol (cocycle) and Rsymbol.
That's also what I think. Not sure if there is a better or cleaner way to do this. |
|
This is very weird, the latest commit, which was just a code suggestion in a doc string, completely changed the CI results, again because of the JET error. That doesn't seem right. |
|
Ok, actually the cocycles were having an incorrect factor |
|
FWIW the Jet error doesn't occur for me just now with Julias 1.10 or 1.11 on OSX. Let me try rebasing this and we'll see how CI does... |
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
I guess we still don't have any idea what's going on here? Any ideas on circumventing the issue? |
|
I have one, do you mind if I try some CI based debugging? I can't replicate this locally on macOS or Linux... |
|
Of course, go ahead! |
|
This fixed the problem for me locally on a linux box, 🙏 |
|
Same here on Windows! |
Build the foundation for adding sectors corresponding to group elements, in order to use$\mathrm{Vec}_{\mathsf{G}}^\omega$ categories, and explicitly implement the case of $\mathbb{Z}_N$ , which will be useful for testing purposes of
UniqueFusionsectors with nontrivialFsymbolvalues.Potentially of interest to @lalooten, @Chenqitrg , @borisdevos .