-
Notifications
You must be signed in to change notification settings - Fork 68
CliffordOperator constructor from PauliOperator
#573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make the small change to the tests for legibility
could you add a mention of this to the changelog
otherwise looks good for merge
of course, only after all tests pass
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 84.27% 84.30% +0.02%
==========================================
Files 108 108
Lines 6575 6581 +6
==========================================
+ Hits 5541 5548 +7
+ Misses 1034 1033 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sagnikpal2004, consider using squash merge for future PRs to maintain linear commit history. Currently, this PR's August 7 commit ( |
|
@Fe-r-oz Thanks, I'll definitely keep that in mind next time! |
This pull request adds support for constructing a
CliffordOperatordirectly from aPauliOperator. It also introduces corresponding tests to ensure the correctness of the new constructor.Changelog
CliffordOperatorthat creates a Clifford operator from aPauliOperator@inlinegetter for thephasesfield of aCliffordOperator.Testing
Notes
PauliOperatorscan be done directly. Need advice if this should simply be left in the test file, or incorporated into the libraryPauliOperatorconstructor from aCliffordOperatoris also possible, and I can create a PR for it if deemed valueable for the library.Dependency of #561