Non-Clifford implementation of sparsification framework, sum over clifford and enhanced magic states#645
Non-Clifford implementation of sparsification framework, sum over clifford and enhanced magic states#645riteshbhirud wants to merge 17 commits intoQuantumSavory:masterfrom
Conversation
|
opened a new PR due to merging issues with previous one. This also addresses the following comments (except for updating docs and tests based on QuantumOpticsBase) from the prev discussion: "Move everything to a module called LowRankNonClifford or a similar name Keep these public: TGate Keep consistent names and APIs with the style of use in Pauli Frame simulations, e.g. pftrajectories and getters related to extracting samples information Rename or restructure display_results should be a show method (see other existing ones) add to this page of the docs https://qc.quantumsavory.org/stable/allops/ have a tests that relies on purely clifford circuits and compares against mctrajectories (using Register and explicit measurements) have a test that relies on QuantumOpticsBase (for very few qubits so it can run efficiently)" |
Krastanov
left a comment
There was a problem hiding this comment.
This is awesome!!! I have a few organiziational and docstring-related comments, otherwise basically ready for merging.
Some of the docstringhelper related comments are find for skipping, just posted them for completeness.
Krastanov
left a comment
There was a problem hiding this comment.
@riteshbhirud , the test failures seem to be in the newly added tests
@Krastanov Thanks for the message, it seems I forgot to reflect some changes I did in the actual code in the tests. Will do that soon. |
|
feel free to convert to non-draft when it is ready for review |
|
@Krastanov Ready for review! I addressed all points from our discussion. |
This implements sparsification framework, sum over clifford and enhanced magic states
1. Sparsification Framework (Section 5.2)
2. Enhanced Magic State Library (Section 5.3)
3. Sum-over-Cliffords Simulation (Section 2.3.2)
4. Fast Metropolis Sampling (Section 4.2)