test that Haah's cubic code is a special case on Multivariate Multicycle code#654
Open
Fe-r-oz wants to merge 3 commits intoQuantumSavory:masterfrom
Open
test that Haah's cubic code is a special case on Multivariate Multicycle code#654Fe-r-oz wants to merge 3 commits intoQuantumSavory:masterfrom
Fe-r-oz wants to merge 3 commits intoQuantumSavory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #606, this PR shows that Haah's cubic code is a special case on MM codes . Haah's cubic code is particularly interesting because it corresponds to a 3D Cubic lattice, hence D = 3 , but it only requires T =2 polynomials. MM code should reproduce this code as well for correctness. The assumption that was made before is that # of orders that corresponds to the order of groups is same as number of polynomials, but in this case as we see that there are three groups (or three variables), but only 2 polynomials A,B. Now, this wrong assertion
(length(orders) == length(polys) || throw(ArgumentError("Mismatch orders/polys"))) is removed because the code does reproduce Haah's cubic code.