Add new symbolic bosonic operators and states #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 76.62% 75.96% -0.67%
==========================================
Files 19 19
Lines 830 828 -2
==========================================
- Hits 636 629 -7
- Misses 194 199 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Krastanov
requested changes
May 11, 2025
There was a problem hiding this comment.
Thanks! A few comments below:
- I noticed two separate pre-existing problems with the
predefined_fockstuff. No need to fix them here, but could you make an issue for each to track them? - Some questions about how things are printed, how things are named, and a few type constraints.
|
migrating ParticleBasis makes sense to me |
This was referenced May 12, 2025
|
@Krastanov let me know when this looks good to merge. |
|
@Krastanov ping. |
Krastanov
approved these changes
Jun 4, 2025
|
LGTM. Failing tests are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add
expressfunctionalities for QuantumOptics and Gabs in separate PRs to make review easier. This review paper is a good quick reference for the quantum objects implemented here.One thing to note: I would like to add symbolic position and momentum operators in the future. With the way the internals of QSymbolics are currently defined, this would require having support for
PositionBasisandMomentumBasistypes in QOBase.jl (https://github.com/qojulia/QuantumOpticsBase.jl/blob/c9c24f96ed9b79a2cb2eeeeb6fc497defedea6a5/src/particle.jl#L6-L63). I suppose we could migrateParticleBasissubtypes into QuantumInterface.jl so that they could be used here? Would that be easy to do? Linking this issue qojulia/QuantumInterface.jl#33.