Add missing express_nolookup for HGate → sHadamard under CliffordRepr#174
Merged
Krastanov merged 3 commits intoQuantumSavory:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
|
Well, this was an embarrassing omission. Thanks for adding it! |
Member
|
Should be in a release version in 15ish minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
express(H, CliffordRepr(), UseAsOperation())fails with:This means
apply!(slot, H)works withQuantumOpticsReprstates but crashes withCliffordReprstates. In contrast,X,Y, andZall have both Clifford and QuantumOptics mappings and work with either backend.The
QuantumOpticsExtalready mapsHGate, andHGateis already imported inQuantumCliffordExt, but theexpress_nolookupmethod for(::HGate, ::CliffordRepr, ::UseAsOperation)was never defined. QuantumClifford providessHadamardas the corresponding symbolic Clifford gate.Fix
Add the one-liner mapping, following the same pattern as the Pauli gates:
Impact
After this fix,
apply!(slot, H)becomes fully representation-agnostic, matching the behavior of X, Y, Z.Discovered while working on a QuantumSavory-based protocol package where switching the default
reprof registers fromCliffordRepr()toQuantumOpticsRepr()(or vice versa) should not require changing gate references.