Implement options and write documentation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests only checks if a user can access depending of being or not being a superuser. The tests and the test cases must be rewritten to handle all possible cases. I tried to test all possibilities but by lack of knowledge and confussion with testing this kind of plug/packages, I finally just do the two tests of this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Quarkex!
In this PR I add the next stuff:
bounce_toandmessageoptions inrequire_authorization/3.require_authorization/3and a explain a bit how to use the plug (change a bit the README and add docs intoChalkAuthorization.Plugmodule.mix format.In the docs configuration of
mix.exsI addedsource_urlandsource_refto make the module and function link to the documentation for the version selected in the HexDocs. But it requires to create a tag for each released version on GitHub, so it is necessary to:v0.1.2.v0.1.0andv0.1.1) to not have broken links in Hexdocs.I already bump the version to 0.1.2, so in case the PR is merged, don't bump it.