-
Notifications
You must be signed in to change notification settings - Fork 0
feat: mdoc cert pull #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SpencerMckayQ
commented
Jan 15, 2026
- pulls the trusted certificates from env: TRUSTED_CERTIFICATES_URL
Signed-off-by: Mckay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for fetching trusted X.509 certificates from a remote URL to configure the agent's X509Module. The certificates URL is read from an environment variable (TRUSTED_CERTIFICATES_URL) and used during agent initialization.
Changes:
- Added new
getAgentModulesWithCertificatesfunction that fetches certificates from a URL before creating agent modules - Modified agent setup to conditionally include X509Module when trusted certificates are provided
- Updated agent initialization in
useBifoldAgentSetupto use the new async function
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/utils/agent.ts | Adds certificate fetching logic, updates module configuration to support X509Module, exports new async function |
| packages/core/src/types/config.ts | Adds trustedCertificatesUrl configuration field |
| packages/core/src/index.ts | Exports new getAgentModulesWithCertificates function |
| packages/core/src/hooks/useBifoldAgentSetup.ts | Updates agent initialization to fetch certificates and adds config dependency |
| packages/core/src/container-impl.ts | Sets default value for trustedCertificatesUrl from environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GrahamS-Quartech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighted issue prevented build.