Skip to content

fix: Check Looped after loaded #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-y-z merged 4 commits into from
Dec 29, 2025
Merged

fix: Check Looped after loaded #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99eacfd
fix: Check Looped after loaded
alex-y-z Dec 12, 2025
4fabf3e
Merge branch 'main' into users/alex-y-z/misc-fixes
alex-y-z Dec 12, 2025
fe1cfe1
Merge branch 'main' into users/alex-y-z/misc-fixes
alex-y-z Dec 15, 2025
0006752
Merge branch 'main' into users/alex-y-z/misc-fixes
alex-y-z Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/animations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"@quenty/baseobject": "file:../baseobject",
"@quenty/enumutils": "file:../enumutils",
"@quenty/humanoidanimatorutils": "file:../humanoidanimatorutils",
"@quenty/instanceutils": "file:../instanceutils",
"@quenty/loader": "file:../loader",
"@quenty/maid": "file:../maid",
"@quenty/promise": "file:../promise",
Expand Down
13 changes: 8 additions & 5 deletions src/animations/src/Shared/AnimationSlotPlayer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ local Maid = require("Maid")
local Promise = require("Promise")
local PromiseMaidUtils = require("PromiseMaidUtils")
local RbxAssetUtils = require("RbxAssetUtils")
local RxInstanceUtils = require("RxInstanceUtils")
local ValueObject = require("ValueObject")

local AnimationSlotPlayer = setmetatable({}, BaseObject)
Expand Down Expand Up @@ -323,15 +324,17 @@ function AnimationSlotPlayer.Play(
end
end)

if not track.Looped then
-- This is a hack to ensure that animations stop at a set rate instead of roblox's weird default faded time
maid:GivePromise(AnimationPromiseUtils.promiseLoaded(track)):Then(function()
-- This is a hack to ensure that animations stop at a set rate instead of roblox's weird default faded time
maid:GivePromise(AnimationPromiseUtils.promiseLoaded(track)):Then(function()
maid:GiveTask(RxInstanceUtils.observePropertyBrio(track, "Looped", function(looped)
return not looped
end):Subscribe(function()
-- This is very very sad...
maid:GiveTask(task.delay(track.Length - track.TimePosition - 2 / 60, function()
track:Stop(fadeTime or self._defaultFadeTime.Value)
end))
end)
end
end))
end)

maid:GiveTask(function()
local stopFadeTime = fadeTime or self._defaultFadeTime.Value
Expand Down