fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.2.0 old fluent_ui 1.8.1 didn't compile anymore #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luent_ui 1.8.1 didn't work anymore
maxeema
changed the title
maxeema
changed the title
Author
|
Guys, I have finished fixes and the better PR to merge is #3 And I close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, team QuickBird!
*
Reference to the issue: #1
*
I will explain my PR. The problem occurred when I tried to run the "flutter_platform_search" demo app on the latest Flutter 2.8.1, as well as on the previous stable 2.5.3 and 2.2.0 releases. Because the Flutter API has been changed (as usual) at some moment, we couldn't run "flutter_platform_search" with the fluent_ui: ^1.8.1 dependency anymore. I tried fluent_ui version 1.9.+, it didn't help. In fluent_ui 2.+ and 3.+ were appeared new breaking changes in the API. So, the better way I found is to migrate the usage of the fluent_ui dependency to its latest version 3.6.0 and to update the WindowsSearchDelegate.buildScaffold() method to make the example compile and work on a fresh Flutter.