-
-
Notifications
You must be signed in to change notification settings - Fork 32
Improve number input #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
supersaiyansubtlety
wants to merge
50
commits into
QuiltMC:develop/2.8
Choose a base branch
from
supersaiyansubtlety:improve-number-input
base: develop/2.8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve number input #326
supersaiyansubtlety
wants to merge
50
commits into
QuiltMC:develop/2.8
from
supersaiyansubtlety:improve-number-input
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b63d604 to
648f32c
Compare
use new installation methods for LineNumbersRuler and PairsMarker
…for multiline snippets
…its not in tooltips
implement NumberInputDialog::promptFloat and use it in ScaleMenu fix bugs related to directly setting NumberTextField's value
…dValue methods make them unecessary
remove NumberInputDialog.MinimumSizeTextArea as it was unecessary validate that step size is not greater than range size
… when it's selected (new french and japanese translations assume same formatting as english)
disable step up/down buttons on input out of range implement alternate stepping
…rInputDialog::promptInt
648f32c to
87cf42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds #321
based on #318
Replaces the
JOptionPanedialogs opened byView > Scale > Custom (N%)...andView > Selection Highlight > Blink delay (Nms)...with customNumberInputDialogs.NumberInputDialogs:Also:
Custom...menu item@RangedFloattoConfig.main().scaleFactorand reduces the max to 5 (from 10)ScaleChangeListenerandScaleUtil::setScaleFactor;TrackedValuemethods make them unnecessaryNotes:
NumberTextFields instead ofJFormattedTextFields because theFormats used byJFormattedTextFieldare too lenient: they seem to ignore all trailing characters after valid input (including.after ints). TheNumberTextFields useInteger::parseInt/Float::parseFloat; the only added leniency is trimming leading/trailing white space.-cannot be mid-number), and it would require a customDocumentwhich would probably require magical toolkit installation and generally increase complexity.menu.view.scale.custom.selectedtranslations for French and Japanese based onmenu.view.scale.customassuming the formatting would be the same as in English; I don't speak French or JapaneseCustom Scale:
Blink Delay: