Menu search #338
Open
Menu search #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersaiyansubtlety
added
enhancement
supersaiyansubtlety
force-pushed
the
menu-search
branch
from
90a12c2 to
ea7d7db
Compare
fix storing leaves a level too high fix overriting children instead of adding to them
improve javadocs
more javadocs
allow mutation via MutableMultiTrie.Node
stop redundant String::contains checks
…ck(0) to prevent sleeping rename SearchableElement's onSearchClicked -> onSearchChosen allow pressing enter when search item or preview is selected to do onSearchChosen
Member
Author
|
ready! |
…ate search results capitalize OS
…cking numerous results
scale SearchMenusMenu.field's font select SearchMenusMenu.field when focusing it
only re-show popup when shrinking stop scaling field font (menu item fonts are automatically scaled)
…nuItem to fix positioning at low scales
give SearchableElement#streamSearchAliases a default implementation
make hint dismiss buttons slightly smaller adjust hint padding
…er because setting it from a HeirarchyListener was buggy (when restoring after viewing, couldn't select with arrow keys; field got duplicated in path)
comment bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Search menus" menu under the "Help" menu.
Tasks
Devmenu)all(most?) current menu items searchablemake selecting a search result also select the corresponding element (if swing allows it)swing does not allow it; instead, hold shift to select the searched item
Yes, the abstraction behind tries is a 'bit' overkill.
Yes, the generics in
CompositeStringMultiTrie* got a little out of hand.Yes, it was fun to write.