Setting the correct type for notes onDelete() and adding onUpdate() in /example_full and parsing the correct type for PhoneLable.mobile #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _noteCard() in example_full\lib\pages\edit_contact_page.dart file erroneously points to _contact.groups for onDelete(). This throws an null/empty error when one adds a note and tries to delete it (as is). This fix ensures the notes property is the one targeted. Adding onUpdate() that was initially null
Both iOS and Android support 'mobile' PhoneLabel. The current parser assigns type('cell') + ('text') or ('msg') which then miss-assigns the label when the contact is read or scanned. The current setup passes TEL;TYPE=cell,msg which is a custom label and not 'mobile' as intended. This PR fixes this by exclusively returning types.add('mobile') for PhoneLabel.mobile
Oneya4
changed the title
Oneya4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _noteCard() in example_full\lib\pages\edit_contact_page.dart file erroneously points to _contact.groups for onDelete(). This throws an null/empty error when one adds a note and tries to delete it (as is). This fix ensures the notes property is the one targeted. Adding onUpdate() that was initially null