fix: improve logger, error handling, and documentation#815
Open
CodyRobot wants to merge 1 commit intoQwenLM:mainfrom
Open
fix: improve logger, error handling, and documentation#815CodyRobot wants to merge 1 commit intoQwenLM:mainfrom
CodyRobot wants to merge 1 commit intoQwenLM:mainfrom
Conversation
- Fix duplicate logger handler issue by checking existing handlers - Improve error message matching in retry logic (case-insensitive) - Add comprehensive docstrings to utility functions - Add default parameter value to extract_text_from_message - Enhance type hints and documentation for better IDE support These changes improve code robustness, maintainability, and developer experience.
CodyRobot
force-pushed
the
fix/logger-and-error-handling-improvements
branch
from
f91f01b to
1f07948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code robustness, maintainability, and developer experience with the following changes:
Changes
qwen_agent/log.py): Added check for existing handlers to prevent duplicate log outputqwen_agent/llm/base.py): Changed to case-insensitive matching and enhanced context length error detectionqwen_agent/utils/utils.py,qwen_agent/llm/base.py): Added complete documentation forjson_loads,extract_text_from_message,retry_model_service, andretry_model_service_iteratorfunctionsqwen_agent/utils/utils.py): Added default parameter value toextract_text_from_messageTesting