fix: correct dotenv dependency to python-dotenv in setup.py#833
Open
mango766 wants to merge 1 commit intoQwenLM:mainfrom
Open
fix: correct dotenv dependency to python-dotenv in setup.py#833mango766 wants to merge 1 commit intoQwenLM:mainfrom
mango766 wants to merge 1 commit intoQwenLM:mainfrom
Conversation
The install_requires lists 'dotenv' but the code imports from the 'python-dotenv' package (from dotenv import load_dotenv). The 'dotenv' package on PyPI is a different, much less popular package that does not provide the same API. Change to 'python-dotenv' which is the correct and widely-used package that provides the dotenv module with load_dotenv().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotenv→python-dotenvinsetup.pyinstall_requiresProblem
setup.pylists'dotenv'as a dependency, but the code uses:The
dotenvandpython-dotenvare different packages on PyPI:from dotenv import load_dotenvpython-dotenvdotenvRunning
pip install dotenvinstalls the wrong package, which does not provideload_dotenv.Solution
Change
'dotenv'to'python-dotenv'ininstall_requires.Test Plan
pip install python-dotenv && python -c "from dotenv import load_dotenv; print('OK')"pip install qwen-agentresolves correctly