Skip to content

Conversation

@Kenzo-Wada
Copy link
Contributor

Migrate build tool from tsup to tsdown.

Benchmark: ~28% faster (2.87s vs 4.00s average)

Removed --env.NODE_ENV production flag as it's unnecessary - the only NODE_ENV usage is isTestMode() which should evaluate at runtime.

Copilot AI review requested due to automatic review settings January 29, 2026 04:09
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: 0d24ede

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the build tool from tsup to tsdown for the @qwikdev/create-astro package, claiming a ~28% performance improvement (2.87s vs 4.00s). The migration removes the --env.NODE_ENV production flag since the only usage of NODE_ENV is in the runtime-evaluated isTest() function.

Changes:

  • Replaced tsup with tsdown as the build tool
  • Updated build scripts to use tsdown commands
  • Migrated configuration from tsup to tsdown (import statement change only)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
libs/create-qwikdev-astro/package.json Updated devDependencies and build scripts to use tsdown instead of tsup
libs/create-qwikdev-astro/tsdown.config.ts Changed import statement from tsup to tsdown (configuration remains identical)
pnpm-lock.yaml Added tsdown v0.20.1 and its dependencies (including rolldown v1.0.0-rc.1), removed tsup and its dependencies
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kenzo-Wada Kenzo-Wada marked this pull request as draft January 29, 2026 04:12
@Kenzo-Wada Kenzo-Wada marked this pull request as ready for review January 29, 2026 04:21
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/astro/@qwikdev/create-astro@275
npm i https://pkg.pr.new/QwikDev/astro/@qwikdev/astro@275

commit: 0d24ede

@siguici
Copy link
Member

siguici commented Jan 29, 2026

Thanks for the PR 🙏

The migration from tsup to tsdown looks solid and all tests are passing 👍

Given the scope of the changes, I’ll still test this version locally and may
make a few adjustments if needed before merging.

Thanks again for the contribution!

@thejackshelton
Copy link
Member

thejackshelton commented Jan 29, 2026

I'm all for moving this to tsdown! For reference, I am currently working on moving the qwik optimizer / compiler to oxc from swc in Rust.

I am also working on:
https://github.com/kunai-consulting/qwik-design-system

Which uses a lot of the oxc toolchain in various parts on the typescript side. All libraries are Qwik libraries with the rolldown config.

@siguici let me know if you need me to review when finished

@Kenzo-Wada
Copy link
Contributor Author

thanks! and nice design system project :)

@siguici
Copy link
Member

siguici commented Feb 2, 2026

Agreed 👍

After local verification, I didn’t find any issues.
Most of the changes are formatting-related, and for the CLI package.json,
all supported runtimes now handle ESM, so this is fine for me.

I’m good to merge.

@siguici siguici merged commit 5b86f4a into QwikDev:main Feb 2, 2026
30 checks passed
@Kenzo-Wada Kenzo-Wada deleted the chore/migrate-tsdown branch February 2, 2026 14:26
@Kenzo-Wada
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants