Skip to content

chore: throw error when importing core twice #7784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: build/v2
Choose a base branch
from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Aug 6, 2025

v2 version of #7109 with vendorRoots removal

this should make it easier to detect build misconfigurations
@wmertens wmertens requested review from a team as code owners August 6, 2025 09:04
Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: 80fa09c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens force-pushed the v2-throw-duplicate branch from 694fb2e to 80fa09c Compare August 6, 2025 09:09
Copy link
Contributor

github-actions bot commented Aug 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 80fa09c

@wmertens
Copy link
Member Author

wmertens commented Aug 6, 2025

the reason playwright errored and now the cli tests that both run vite in ssr server mode which loads vite config with uses qwik-router vite plugin, which imports qwik core, and then the preview server runs in-process with its own qwik core copy. So it's actually a bug in our bundling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants