Skip to content

fix(vite): deadlock in rolldown-vite #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
+2 −4
Merged

fix(vite): deadlock in rolldown-vite #7807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/qwik/src/optimizer/src/plugins/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,9 +759,8 @@ export function createQwikPlugin(optimizerOptions: OptimizerOptions = {}) {
// unchanged imports are not missing in our internal transform cache
// This can happen in the repl when the plugin is re-initialized
// and possibly in other places
for (const id of deps.values()) {
await ctx.load({ id });
}
// NOTE: this should be Promise.all to avoid deadlocks
await Promise.all([...deps.values()].map((id) => ctx.load({ id })));

ctx.addWatchFile(id);

Expand Down
1 change: 0 additions & 1 deletion starters/e2e/qwikcity/nav.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { $ } from "bun";
import {
assertPage,
getScrollHeight,
Expand Down
Loading