Remove schedule generation on user creation #540
Conversation
…lly get generated
dosubot
bot
added
the
size:S
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
this-Aditya
left a comment
this-Aditya
left a comment
There was a problem hiding this comment.
Hi Pauline, please see the comments inline. Other than that, this PR looks good. Thanks.
I'll make sure to add this in the latest version as well
| if (!user.getAttributes().equals(userDto.getAttributes()) | ||
| || !user.getTimezone().equals(userDto.getTimezone()) | ||
| || !user.getEnrolmentDate().equals(userDto.getEnrolmentDate()) | ||
| || !user.getLanguage().equals(userDto.getLanguage())) | ||
| { |
There was a problem hiding this comment.
If I'm not wrong, the /schedule endpoint will be called by the questionnaire app. Do we have checks in the app to ensure that this endpoint is only called when updating the user, and only if these properties don’t match?
There was a problem hiding this comment.
Oh yes the user will be calling the update endpoint from the app anyway so they can just call the schedule endpoint afterwards. We can make the updates afterwards in a separate PR since we have not enabled the app server scheduling yet for users.
| // Generate schedule for user | ||
| this.scheduleService.generateScheduleForUser(savedUser); |
There was a problem hiding this comment.
I don't see any use of the schedulerService variable, this can be removed.
/scheduleendpoint can simply get called