-
Notifications
You must be signed in to change notification settings - Fork 3
Added CI Setup and Integration Tests for Microservices #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
this-Aditya
wants to merge
27
commits into
docker-setup
Choose a base branch
from
ci-setup
base: docker-setup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds:
Notes:
A new module for integration tests has been added under the microservices folder. This is done because the integration tests need to interact with all microservices at once. Therefore, it makes more sense to have a separate module for these tests, instead of including them in any single microservice.
The main workflow for microservices builds all the services in parallel. The Docker job creates images for all services and performs other tasks. The integration tests run after all the Docker jobs are complete.
The environment variables generated during the Docker job are passed to the integration tests.
One concern is the redundancy that arises when Docker images are built twice. If the Docker job successfully pushes the images, the integration test job will use those pushed images to run the tests. However, when the images are not pushed, the integration test job rebuilds the images, resulting in duplication. To address this, should I use
actions/upload-artifactto transfer the Docker images from the docker job to the integration test job when they are not pushed to the registry. However, this might cause storage issues due to the size of the images. Any suggestions for reducing the need to rebuild the images would be appreciated.I am attaching an image showing the execution flow of the microservices-main workflow for reference:
