Added path based system functionality from radar-output-restructure#121
Draft
this-Aditya wants to merge 16 commits intodevfrom
Draft
Added path based system functionality from radar-output-restructure#121this-Aditya wants to merge 16 commits intodevfrom
this-Aditya wants to merge 16 commits intodevfrom
Conversation
Added Integration Tests for File Upload Endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Functionalities from Radar-Output for Consistent Path-Based Structure
This functionality has not been extracted from
radar-output-restructureand moved toradar-commonsbecause some differences arise when usingradar-gateway. Hence, these functionalities are added separately toradar-gatewaywith slight modifications, as listed below:Modifications:
Key-Value Handling:
The
radar-output-restructureuses thekeyandvalueparameters as a generic record, but this approach has not been adopted forradar-gateway.For example, consider the
sendmethod from the phone audio input plugin in radar-commons-android.It sends the Kafka topic’s key-value pair separately from the audio file. Hence, key and value path-formatted plugins have been removed.
Path Formatter Extensions Handling:
The extensions in
radar-outputare not part ofPathFormatterParameters, and they need to be supplied toFormattedPathFactory::initas a parameter or otherwise toPathConfig::createFactory.This approach is not suitable for
radar-gatewaybecause, for every request, all components for path formatting get regenerated, and previous objects are discarded if the extension is explicitly passed every time.To simplify this, the extension configuration has been moved to
PathFormatParameterand this can be passed for every request with recreating objectsFile Naming Consistency:
Every file field will have a random UUID appended as a suffix to maintain consistency with the current file upload approach.
Removal of the Attempts Field:
The
attemptsfield has been removed as it is not currently used inradar-gateway.Some other minor changes.