Fix: Environment variable access logic for config#127
Merged
this-Aditya merged 6 commits intodevfrom Jan 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the environment variable handling in configuration classes to properly prioritize environment variables over local configuration values. The previous implementation only read from environment variables when config values were null, which didn't allow environment variables to override non-null local config values.
Changes:
- Changed configuration properties from mutable (
var) to immutable (val) to support functional-style configuration updates - Replaced
checkEnvironmentVars()methods withwithEnv()methods using radar-jersey helper functions (copyEnv,copyOnChange) - Modified the configuration loading flow in Main.kt to call
withEnv()during initialization rather than checking environment variables after validation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| S3StoragePathConfig.kt | Converts properties to immutable and adds withEnv() method to apply environment variable for path prefix |
| S3StorageConfig.kt | Converts properties to immutable and adds withEnv() method to apply environment variables for S3 configuration (URL, access key, secret key, bucket name, region, and nested path config) |
| GatewayConfig.kt | Replaces checkEnvironmentVars() with withEnv() method to propagate environment variable handling to S3 storage configuration |
| Main.kt | Integrates withEnv() into the configuration loading chain after withDefaults() and removes the separate checkEnvironmentVars() call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
radar-gateway/src/main/kotlin/org/radarbase/gateway/config/S3StoragePathConfig.kt
Outdated
Show resolved
Hide resolved
radar-gateway/src/main/kotlin/org/radarbase/gateway/config/S3StoragePathConfig.kt
Show resolved
Hide resolved
radar-gateway/src/main/kotlin/org/radarbase/gateway/config/S3StoragePathConfig.kt
Outdated
Show resolved
Hide resolved
Merged
mpgxvii
approved these changes
Jan 23, 2026
radar-gateway/src/main/kotlin/org/radarbase/gateway/config/S3StorageConfig.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config values are only read from environment variables if they are null. This doesn’t prioritize environment variables above local config values. The logic now uses the
radar-jerseyhelper functions to prioritize environment variables over local configuration, checking the environment variables every time.