Skip to content

feature/ory-based-auth#4303

Open
pvannierop wants to merge 10 commits intomainfrom
feature/sep-oauth2
Open

feature/ory-based-auth#4303
pvannierop wants to merge 10 commits intomainfrom
feature/sep-oauth2

Conversation

@pvannierop
Copy link
Copy Markdown
Contributor

@pvannierop pvannierop commented Jun 6, 2025 •
edited by mpgxvii
Loading

This PR will add the necessary changed for Ory based authentication using the Kratos and Hydra services.

TODO:

  • Release MP3.0.0
  • Bump chart versions

@pvannierop pvannierop requested review from EIjo and ewelinajozwik June 6, 2025 08:37
@pvannierop pvannierop self-assigned this Jun 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@pvannierop pvannierop force-pushed the feature/sep-oauth2 branch from 557a88e to f24a95b Compare June 11, 2025 12:53
mpgxvii
mpgxvii reviewed Dec 16, 2025
View reviewed changes
charts/radar-fitbit-connector/values.yaml
oauthClientSecret: secret
# -- OAuth2 Auth URL for connector client to get access tokens
auth_url: http://management-portal:8080/managementportal/oauth/token
auth_url: http://radar-hydra-public:4444/oauth2/token
Copy link
Copy Markdown
Member

@mpgxvii mpgxvii Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just keep MP as default for now?

mpgxvii
mpgxvii reviewed Dec 19, 2025
View reviewed changes
charts/radar-rest-sources-backend/templates/configmap.yaml

auth:
# Management Portal URL
managementPortalUrl: {{ .Values.managementportal_url }}
Copy link
Copy Markdown
Member

@mpgxvii mpgxvii Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this should be removed?

@pvannierop pvannierop requested a review from mpgxvii December 22, 2025 12:08
@pvannierop
Copy link
Copy Markdown
Contributor Author

pvannierop commented Dec 22, 2025

@mpgxvii Hi Pauline. I reviewed the Ory helm chart PR review. I added some comments (not all directed to you BTW). If we could settle on these last remaining issues we can merge the functionality. The main discussion item is whether we provide defaults to run with Ory or with MP. Preferably, I would like to see it run in dual mode. Is that possible?

@yatharthranjan
Copy link
Copy Markdown
Member

yatharthranjan commented Jan 13, 2026

Hi both.
i think Ory+SEP is still not as well documented as MP. Until we have that we should keep MP as default for the community. But we can keep MP as default and provide a mod to switch to Ory+SEP in RADAR-kubernetes which can be enabled with a simple flag in production.yaml?

@pvannierop
Copy link
Copy Markdown
Contributor Author

pvannierop commented Feb 2, 2026

@yatharthranjan Ok, good that you mention this. @ewelinagr and I discussed this same issue (and judged differently). I am happy to see that we see the same. I will make Ory optional with a helmfile mod file in RADAR-Kubernetes.

@mpgxvii mpgxvii mentioned this pull request Feb 9, 2026
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EIjo EIjo Awaiting requested review from EIjo

@ewelinajozwik ewelinajozwik Awaiting requested review from ewelinajozwik

@mpgxvii mpgxvii Awaiting requested review from mpgxvii

At least 1 approving review is required to merge this pull request.

Assignees

@pvannierop pvannierop

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvannierop @yatharthranjan @mpgxvii