fix: Champion hover visibility during ban phase and config access, ad…#185
Open
Wichtowski wants to merge 1 commit intoRCVolus:masterfrom
Open
fix: Champion hover visibility during ban phase and config access, ad…#185Wichtowski wants to merge 1 commit intoRCVolus:masterfrom
Wichtowski wants to merge 1 commit intoRCVolus:masterfrom
Conversation
…d team prefixes & phase Labels to config, add override for development Changes: - Fixed champion hover visibility during ban phase by properly setting champion data in converter.ts - Fixed TypeScript error in LeagueDataProviderService.ts by using state.getConfig() instead of state.config - Added missing config argument in Recorder.ts for RecordingDatapoint constructor - Added documentation for config.override.json in README.md All changes are backward compatible and maintain existing functionality while fixing the hover visibility issue during bans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d team prefixes & phase Labels to config, add override for development
Changes:
All changes are backward compatible and maintain existing functionality while fixing the hover visibility issue during bans.