Add network variants to GetPeerInfoResultNetwork #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
could you please rebase, it looks #1 touched the network variants also... |
|
Added corresponding PR to upstream rust-bitcoin#200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing network type variants that are found in
bitcoin/src/netbase.cpp.In particular I had to addNotPubliclyRoutableto fix tests when updatingbitcoindto use bitcoin version 0.22, see rust-bitcoin/bitcoind#30.#1 added
NotPubliclyRoutableso this PR only adds the other missing variants that are present inbitcoin/src/netbase.cppversion 22.0 .