Conversation
- parameterise e2e tests for RDF4JClient to include GraphDBClient - delete e2e graphdb tests that are already part of paramterised tests
With additional refactorings: - RDF4JError as base exception class - Rename RepositoryFormatError to RepositoryResponseFormatError to align with naming convention of GraphDB's ResponseFormatError class - Add handling for GraphDB specific health check in tests - Add tests for graphdb client
- also refactor client namespacing
rdflib/contrib/graphdb/client.py
Outdated
| return self._graphdb_repository_manager | ||
|
|
||
| @property | ||
| def repos(self) -> RepositoryManagement: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
This is one aspect of the API design that I would like feedback on. Both RDF4J and GraphDB provide a set of repository level APIs. The repositories namespace is for RDF4J while repos is used here for GraphDB. I'm open to suggestions for better namespace naming to distinguish between the two.
There was a problem hiding this comment.
Got it. My proposal then is to rename repos to graphdb_repositories for clarity.
There was a problem hiding this comment.
Renamed to graphdb_repositories in commit b0d1efc
There was a problem hiding this comment.
The docs should be updated as well https://github.com/RDFLib/rdflib/pull/3383/changes
There was a problem hiding this comment.
Thanks for the reminder! I've fixed it in the other PR in commit 74d8e98
| @@ -0,0 +1,4 @@ | |||
| FROM ontotext/graphdb:10.8.12 | |||
There was a problem hiding this comment.
Something to be discussed internally, the current version of GraphDB is 11, but we use here 10, because since version 11 the license is mandatory. We should consider issuing a license for testing purposes.
|
@nelly-hateva FYI, the user docs can be reviewed in this PR #3383 |
Remove the `TalkToYourGraph` management class and its integration in `GraphDBClient` as it is experimental and not intended for public consumption. Related unit and E2E tests have also been removed.
4 participants
Summary of changes
This PR introduces a GraphDB Client in RDFLib. It wraps the GraphDB REST API and provides programmatic management and administration of GraphDB instances.
GraphDB's REST API endpoints are grouped by tags. The following is a list of tags currently implemented and supported by the RDFLib GraphDB Client.
The remaining GraphDB REST API tags are not yet implemented.
See the API reference documentation preview on read the docs.
User-facing documentation will be added soon in a separate PR.Update: The user docs can now be reviewed in PR #3383. The preview link is at: https://rdflib--3383.org.readthedocs.build/en/3383/graphdb/
Checklist
the same change.
./examples.so maintainers can fix minor issues and keep your PR up to date.