Fix test_cli that were failing because the endpoint http://ja.dbpedia.org/sparql is down
#245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now these tests are using the main dbpedia and are not anymore checking for exact value returned (instead just checking if there are results)
That said, of course there can't be a single day without an endpoint going down (what a joke, this is so unreliable, I really wonder why SPARQL is not more popular 🤔), so while I fixed thi the LOV fuseki endpoint went down (https://lov.linkeddata.es/dataset/lov/sparql), returning this error:
Not going to fix this one. Not worth it, I prefer put the time I have for this on rdflib SPARQLStore.
It will probably go back up soon since I think it's actually used by people (unlike dbpedia)
You'll need to manually trigger the tests when it's back up @nicholascar